Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): wildcard implicit dependency should support scoped project names #15699

Merged

Conversation

AgentEnder
Copy link
Member

Current Behavior

Wildcards don't function as expected in project based repositories because @org/package doesn't match * as a glob pattern. **/* would perform the expected match, but isn't what we want.

Expected Behavior

* selects expected projects

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Mar 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 15, 2023 at 8:34PM (UTC)

@FrozenPandaz FrozenPandaz merged commit cc68012 into nrwl:master Mar 15, 2023
FrozenPandaz pushed a commit that referenced this pull request Mar 15, 2023
meeroslav pushed a commit to meeroslav/nx that referenced this pull request Mar 16, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants